Differential D20729

Convert "Empower" from state-based MFA to one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Aug 22 2019, 2:07 PM.

Details

Reviewers: None
Maniphest Tasks: T13382: Update various user account CLI tools
Commits: rP109d7dcaf197: Convert "Empower" from state-based MFA to one-shot MFA

Summary

Ref T13382. Currently, the "Make Administrator" action in the web UI does state-based MFA. Convert it to one-shot MFA.

Test Plan

Empowered and unempowered a user from the web UI, got one-shot MFA'd. Empowered a user from the CLI, no MFA issues.

Diff Detail

Repository

rP Phabricator

Branch

adminmfa1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23280
Build 31987: Run Core Tests
Build 31986: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 22 2019, 2:07 PM

Harbormaster completed remote builds in B23280: Diff 49422.Aug 22 2019, 2:08 PM

epriestley requested review of this revision.Aug 22 2019, 2:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2019, 3:34 PM

Closed by commit rP109d7dcaf197: Convert "Empower" from state-based MFA to one-shot MFA (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP109d7dcaf197: Convert "Empower" from state-based MFA to one-shot MFA.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleEmpowerController.php

11 lines

xaction/

PhabricatorUserEmpowerTransaction.php

7 lines

Diff 49422

View Options

src/applications/people/controller/PhabricatorPeopleEmpowerController.php