Differential D20704

When the feed query on project profile pages overheats, contain the damage
ClosedPublic
Actions

Authored by epriestley on Aug 8 2019, 5:37 PM.

Details

Reviewers: None
Maniphest Tasks: T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core
Commits: rP0a3c26998fc9: When the feed query on project profile pages overheats, contain the damage

Summary

Ref T13349. This is almost the same change as D20678, but for project profiles instead of user profiles.

The general reproduction case is "view a project where you can't see more than 50 of the 500 most recent feed stories".

Test Plan

Forced all queries to overheat.
Viewed a project profile page.
Before: overheating fatal near top level.
After: damage contained to feed panel.

Diff Detail

Repository

rP Phabricator

Branch

overheat2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23238
Build 31923: Run Core Tests
Build 31922: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 8 2019, 5:37 PM

Harbormaster completed remote builds in B23238: Diff 49373.Aug 8 2019, 5:39 PM

epriestley requested review of this revision.Aug 8 2019, 5:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 9 2019, 4:01 AM

Closed by commit rP0a3c26998fc9: When the feed query on project profile pages overheats, contain the damage (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0a3c26998fc9: When the feed query on project profile pages overheats, contain the damage.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectProfileController.php

33 lines

Diff 49373

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

When the feed query on project profile pages overheats, contain the damageClosedPublicActions