Page MenuHomePhabricator

When the feed query on project profile pages overheats, contain the damage
ClosedPublic

Authored by epriestley on Aug 8 2019, 5:37 PM.
Tags
None
Referenced Files
F13044191: D20704.diff
Wed, Apr 17, 3:10 PM
Unknown Object (File)
Thu, Apr 11, 7:19 AM
Unknown Object (File)
Thu, Apr 11, 4:28 AM
Unknown Object (File)
Tue, Apr 9, 12:26 AM
Unknown Object (File)
Fri, Apr 5, 1:50 PM
Unknown Object (File)
Tue, Apr 2, 4:30 PM
Unknown Object (File)
Sat, Mar 30, 8:33 AM
Unknown Object (File)
Fri, Mar 29, 9:55 AM
Subscribers
None

Details

Summary

Ref T13349. This is almost the same change as D20678, but for project profiles instead of user profiles.

The general reproduction case is "view a project where you can't see more than 50 of the 500 most recent feed stories".

Test Plan
  • Forced all queries to overheat.
  • Viewed a project profile page.
  • Before: overheating fatal near top level.
  • After: damage contained to feed panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 9 2019, 4:01 AM
This revision was automatically updated to reflect the committed changes.