Paths

Table of Contentst

Differential D20693

Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior
ClosedPublic
Actions

Authored by epriestley on Aug 1 2019, 7:06 PM.

Tags

None

Referenced Files

	F14901124: D20693.diff
	Sun, Feb 9, 12:41 PM

	F14893851: D20693.id49354.diff
	Sun, Feb 9, 7:56 AM

	F14893850: D20693.id49353.diff
	Sun, Feb 9, 7:56 AM

	F14893849: D20693.id.diff
	Sun, Feb 9, 7:56 AM

	Unknown Object (File)
	Fri, Feb 7, 1:55 PM

	Unknown Object (File)
	Thu, Jan 30, 5:01 AM

	Unknown Object (File)
	Wed, Jan 29, 6:12 AM

	Unknown Object (File)
	Sat, Jan 25, 5:24 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog
Commits: rP3069ef41662d: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand…

Summary

Fixes T13363. Currently, these are genuine links which we intercept events for.

Make them pseudolinks instead. Possible alternative approaches are:

Keep them as genuine links, but mark them as non-navigation links for Quicksand. (But: yuck, weird special case.)
Keep them as genuine links, and have the dialog handler JX.Stratcom.pass() to see if anything handles the event. (But: the "pass()" pattern generally feels bad.)

"Tableaus" or whatever comes out of T10469 some day will probably break everything anyway?

Test Plan

Opened the "Edit Related Tasks... > Edit Subtasks" dialog.
Clicked task title links (not the "open in new window" icon, and not the "Select" button).
Before: Dialog (sometimes) closed abruptly.
After: Task is consistently selected as part of the attachment set.

Diff Detail

Repository

Branch

sub1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23218
Build 31892: Run Core Tests
Build 31891: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 1 2019, 7:06 PM

Harbormaster completed remote builds in B23218: Diff 49353.Aug 1 2019, 7:08 PM

epriestley requested review of this revision.Aug 1 2019, 7:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 7:25 PM

Closed by commit rP3069ef41662d: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP3069ef41662d: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

core/

behavior-object-selector.js

2 lines

Diff 49353

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/behavior-object-selector.js

Loading...