Page MenuHomePhabricator

Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior
ClosedPublic

Authored by epriestley on Aug 1 2019, 7:06 PM.
Tags
None
Referenced Files
F13099110: D20693.diff
Fri, Apr 26, 1:12 PM
Unknown Object (File)
Wed, Apr 24, 4:53 PM
Unknown Object (File)
Sun, Apr 14, 9:53 AM
Unknown Object (File)
Mar 21 2024, 7:19 AM
Unknown Object (File)
Mar 4 2024, 7:58 PM
Unknown Object (File)
Feb 9 2024, 1:25 AM
Unknown Object (File)
Feb 3 2024, 11:03 PM
Unknown Object (File)
Dec 23 2023, 3:59 AM
Subscribers
None

Details

Summary

Fixes T13363. Currently, these are genuine links which we intercept events for.

Make them pseudolinks instead. Possible alternative approaches are:

  • Keep them as genuine links, but mark them as non-navigation links for Quicksand. (But: yuck, weird special case.)
  • Keep them as genuine links, and have the dialog handler JX.Stratcom.pass() to see if anything handles the event. (But: the "pass()" pattern generally feels bad.)

"Tableaus" or whatever comes out of T10469 some day will probably break everything anyway?

Test Plan
  • Opened the "Edit Related Tasks... > Edit Subtasks" dialog.
  • Clicked task title links (not the "open in new window" icon, and not the "Select" button).
  • Before: Dialog (sometimes) closed abruptly.
  • After: Task is consistently selected as part of the attachment set.

Diff Detail

Repository
rP Phabricator
Branch
sub1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23218
Build 31892: Run Core Tests
Build 31891: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 7:25 PM
This revision was automatically updated to reflect the committed changes.