Differential D20678

Contain fallout from overheating feed queries on user profile pages
ClosedPublic
Actions

Authored by epriestley on Jul 23 2019, 11:02 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core

Commits

rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages

Summary

Fixes T13349. If the user profile page feed query overheats, it currently takes the whole page with it. Contain the blast to a smaller radius.

Test Plan

Screen Shot 2019-07-23 at 4.01.09 PM.png (1×2 px, 346 KB)

Diff Detail

Repository

rP Phabricator

Branch

overheat1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23182
Build 31842: Run Core Tests
Build 31841: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 23 2019, 11:02 PM

Harbormaster completed remote builds in B23182: Diff 49315.Jul 23 2019, 11:04 PM

epriestley requested review of this revision.Jul 23 2019, 11:04 PM

amckinley accepted this revision.Jul 24 2019, 2:14 AM

This revision is now accepted and ready to land.Jul 24 2019, 2:14 AM

Closed by commit rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages (authored by epriestley). · Explain WhyJul 24 2019, 2:09 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages.

epriestley mentioned this in D20704: When the feed query on project profile pages overheats, contain the damage.Aug 8 2019, 5:37 PM

epriestley mentioned this in rP0a3c26998fc9: When the feed query on project profile pages overheats, contain the damage.Aug 9 2019, 4:01 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileViewController.php

35 lines

Diff 49315

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Contain fallout from overheating feed queries on user profile pagesClosedPublicActions