Page MenuHomePhabricator

Allow daemons to be run in the foreground
AbandonedPublic

Authored by joshuaspence on Jul 8 2019, 3:00 AM.
Tags
None
Referenced Files
F13088922: D20643.diff
Thu, Apr 25, 1:36 AM
Unknown Object (File)
Mon, Apr 22, 9:23 AM
Unknown Object (File)
Fri, Apr 19, 6:30 AM
Unknown Object (File)
Fri, Apr 19, 3:16 AM
Unknown Object (File)
Fri, Apr 19, 3:16 AM
Unknown Object (File)
Thu, Apr 11, 9:16 AM
Unknown Object (File)
Thu, Apr 11, 4:24 AM
Unknown Object (File)
Sun, Mar 31, 11:20 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently there's no way to run all daemons in the foreground.

  • bin/phd start executes all daemons in the background.
  • bin/phd launch executes a single daemon in the background.
  • bin/phd debug executes a single daemon in the foreground, but also enables verbose log output.

Add a --foreground flag to bin/phd start and bin/phd launch to allow daemons to be executed in the foreground. I plan to use this as an entrypoint in a Docker container.

Test Plan

Ran the following commands alongside bin/worker flood and verified that daemons were functional:

    • bin/phd start
  • bin/phd start --foreground
  • bin/phd launch task
  • bin/phd launch --foreground task
  • bin/phd debug task

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 23114
Build 31736: Run Core Tests
Build 31735: arc lint + arc unit

Event Timeline

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
25

Unrelated fix

We don't have any customer use cases for this so I'm not interested in bringing it upstream at this time.

This revision now requires changes to proceed.Jul 8 2019, 3:10 PM