Make "phd start" and "phd reload" use the process list, not PID files
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 9:57 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date

Commits

rP2498e373b955: Make "phd start" and "phd reload" use the process list, not PID files

Summary

Ref T13321. This gets rid of the last pidfile readers in Phabricator; we just use the process list instead.

These commands always only work on the current instance since they don't make much sense otherwise.

Test Plan

Ran bin/phd start and bin/phd reload with and without daemons running.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 20 2019, 9:57 PM

Harbormaster completed remote builds in B23014: Diff 49142.Jun 20 2019, 9:59 PM

epriestley requested review of this revision.Jun 20 2019, 9:59 PM

amckinley accepted this revision.Jun 20 2019, 10:46 PM

This revision is now accepted and ready to land.Jun 20 2019, 10:46 PM

Closed by commit rP2498e373b955: Make "phd start" and "phd reload" use the process list, not PID files (authored by epriestley). · Explain WhyJun 24 2019, 6:27 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2498e373b955: Make "phd start" and "phd reload" use the process list, not PID files.

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

management/

PhabricatorDaemonManagementStatusWorkflow.php

10 lines

PhabricatorDaemonManagementWorkflow.php

107 lines

Diff 49171

View Options

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php