Page MenuHomePhabricator
Differential D20588

In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException"
ClosedPublic
Actions

Authored by epriestley on Jun 18 2019, 3:02 PM.
Tags
None
Referenced Files
F14413159: D20588.diff
Tue, Dec 24, 1:51 PM
Unknown Object (File)
Thu, Dec 19, 1:04 AM
Unknown Object (File)
Fri, Dec 13, 4:56 AM
Unknown Object (File)
Fri, Dec 13, 4:56 AM
Unknown Object (File)
Fri, Dec 13, 4:56 AM
Unknown Object (File)
Sat, Dec 7, 2:38 PM
Unknown Object (File)
Thu, Dec 5, 7:35 PM
Unknown Object (File)
Wed, Nov 27, 10:43 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13315: "bin/repository reparse" stops when encountering a "PhabricatorWorkerPermanentFailureException", but should continue
Commits
rP731b45d81847: In "bin/repository reparse", continue on…
Summary

Fixes T13315. See that task for discussion.

Without --background, we currently treat this as a catastrophic failure, but it's relatively routine for some repository states. We can safely continue reparsing other steps.

Test Plan

Ran bin/repository reparse --all X --message with commits faked to all be unreachable. Got warnings instead of a hard failure on first problem.

Diff Detail

Repository
rP Phabricator
Branch
reparse1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22981
Build 31543: Run Core Tests
Build 31542: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
management/
24 lines

Diff 49106

View Options

src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php

Loading...
Phabricator · Built by Phacility