In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException"
ClosedPublic
Actions

Authored by epriestley on Jun 18 2019, 3:02 PM.

Details

Reviewers

Maniphest Tasks

T13315: "bin/repository reparse" stops when encountering a "PhabricatorWorkerPermanentFailureException", but should continue

Commits

rP731b45d81847: In "bin/repository reparse", continue on…

Summary

Fixes T13315. See that task for discussion.

Without --background, we currently treat this as a catastrophic failure, but it's relatively routine for some repository states. We can safely continue reparsing other steps.

Test Plan

Ran bin/repository reparse --all X --message with commits faked to all be unreachable. Got warnings instead of a hard failure on first problem.

Diff Detail

Repository

rP Phabricator

Branch

reparse1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22981
Build 31543: Run Core Tests
Build 31542: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 18 2019, 3:02 PM

Harbormaster completed remote builds in B22981: Diff 49106.Jun 18 2019, 3:03 PM

epriestley requested review of this revision.Jun 18 2019, 3:03 PM

amckinley accepted this revision.Jun 18 2019, 5:24 PM

This revision is now accepted and ready to land.Jun 18 2019, 5:24 PM

Closed by commit rP731b45d81847: In "bin/repository reparse", continue on… (authored by epriestley). · Explain WhyJun 18 2019, 6:33 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP731b45d81847: In "bin/repository reparse", continue on….

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

management/

PhabricatorRepositoryManagementReparseWorkflow.php

24 lines

Diff 49106

View Options

src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php

In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException"ClosedPublicActions