Page MenuHomePhabricator

Fix two straggling pagination issues in Drydock
ClosedPublic

Authored by epriestley on May 23 2019, 6:55 PM.
Tags
None
Referenced Files
F15415751: D20553.diff
Thu, Mar 20, 7:44 AM
F15382607: D20553.id49034.diff
Fri, Mar 14, 1:21 PM
F15381991: D20553.id49028.diff
Fri, Mar 14, 10:15 AM
Unknown Object (File)
Feb 17 2025, 4:54 AM
Unknown Object (File)
Jan 26 2025, 7:40 AM
Unknown Object (File)
Jan 24 2025, 12:39 PM
Unknown Object (File)
Jan 21 2025, 10:36 AM
Unknown Object (File)
Jan 18 2025, 4:14 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13289. See https://discourse.phabricator-community.org/t/fatal-error-in-pagination-in-drydock-resources-host-logs-all-logs/2735.

bin/drydock lease and the web UI for reviewing all object logs when there is more than one page of logs didn't get fully updated to the new cursors.

  • Use a cursor pager in bin/drydock lease.
  • Implement withIDs() in LeaseQuery so the default paging works properly.
Test Plan
  • Ran bin/drydock lease, got a lease with log output along the way.
  • Set page size to 2, viewed host logs with multiple pages, paged to page 2.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable