Page MenuHomePhabricator

When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email
ClosedPublic

Authored by epriestley on May 22 2019, 10:15 PM.
Tags
None
Referenced Files
F15420506: D20548.id49011.diff
Fri, Mar 21, 2:30 PM
F15420477: D20548.diff
Fri, Mar 21, 2:16 PM
F15420432: D20548.id.diff
Fri, Mar 21, 2:02 PM
F15420075: D20548.id49019.diff
Fri, Mar 21, 11:06 AM
F15419587: D20548.id49019.diff
Fri, Mar 21, 7:10 AM
F15414275: D20548.diff
Wed, Mar 19, 11:51 PM
Unknown Object (File)
Sat, Feb 22, 3:19 PM
Unknown Object (File)
Fri, Feb 21, 1:36 PM
Subscribers
None

Details

Summary

Ref T13289. When you create a Phriction document, you currently get an email with the whole new content as a "diff".

You also get extra transactions in the email and on the page.

This is because Phriction isn't on EditEngine and doesn't mark "create" transactions in a modern way. Get them marked properly to fix these obviously-broken behaviors. This can all go away once Phriction switches to EditEngine, although I don't have any particular plans to do that in the immediate future.

Test Plan
  • Created a new document, viewed email, no longer saw redundant "edited content" transaction or "CHANGES TO CONTENT" diff.
  • Updated a document, viewed email, got interdiff.

Diff Detail

Repository
rP Phabricator
Branch
wiki1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22887
Build 31398: Run Core Tests
Build 31397: arc lint + arc unit