Differential D20493

Make branch status more clear on Diffusion branches view
ClosedPublic
Actions

Authored by epriestley on May 3 2019, 5:11 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"

Commits

rPc5ecc388a212: Make branch status more clear on Diffusion branches view

Summary

See PHI1225. Ref T13277. In Diffusion, show "default", "permanent", or "not permanent" when looking at branches.

For repositories with 100 or fewer branches, put default and permanent branches on top.

Test Plan

Screen Shot 2019-05-03 at 10.10.13 AM.png (1×1 px, 272 KB)

Diff Detail

Repository

rP Phabricator

Branch

branch1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22758
Build 31204: Run Core Tests
Build 31203: arc lint + arc unit

Event Timeline

epriestley created this revision.May 3 2019, 5:11 PM

Harbormaster completed remote builds in B22758: Diff 48885.May 3 2019, 5:13 PM

epriestley requested review of this revision.May 3 2019, 5:13 PM

epriestley mentioned this in T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.May 3 2019, 5:35 PM

Typo in commit message

amckinley accepted this revision.May 16 2019, 1:03 PM

amckinley edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.May 16 2019, 1:05 PM

Closed by commit rPc5ecc388a212: Make branch status more clear on Diffusion branches view (authored by epriestley). · Explain WhyMay 16 2019, 7:24 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc5ecc388a212: Make branch status more clear on Diffusion branches view.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBranchTableController.php

40 lines

view/

DiffusionBranchListView.php

13 lines

Diff 48885

View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php