Page MenuHomePhabricator

Add support for custom "Wait for Approval" instructions
ClosedPublic

Authored by epriestley on May 3 2019, 3:29 PM.
Tags
None
Referenced Files
F15548933: D20492.id48935.diff
Sun, Apr 27, 2:56 AM
F15546971: D20492.diff
Sat, Apr 26, 5:35 PM
F15480387: D20492.id48884.diff
Apr 8 2025, 1:55 PM
F15448228: D20492.id48935.diff
Mar 28 2025, 3:37 AM
F15443208: D20492.id48884.diff
Mar 27 2025, 3:02 AM
F15436206: D20492.id.diff
Mar 25 2025, 12:34 PM
F15431932: D20492.diff
Mar 24 2025, 3:24 PM
F15427139: D20492.id.diff
Mar 23 2025, 1:05 PM
Subscribers
Tokens
"Love" token, awarded by kylec.

Details

Reviewers
amckinley
Summary

See PHI1229. An install has a somewhat duct-taped registration flow which can dump users on the "Wait for Approval" screen without clear guidance. The desired guidance is something like "this is totally normal, just wait a bit for a bot to approve you".

Adding guidance here is generally reasonable and consistent with the intent of this feature.

Test Plan

Screen Shot 2019-05-03 at 8.26.17 AM.png (765×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Branch
instructions1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22757
Build 31202: Run Core Tests
Build 31201: arc lint + arc unit

Event Timeline

And, obviously, fixing the flow to just work would be ideal, but that's like a thousand miles away through the swamps of T5953, and maybe not even then in this case (where part of the issue was using provider X as an authority, and provider Y as an actual login provider).

This revision is now accepted and ready to land.May 16 2019, 1:01 PM