Page MenuHomePhabricator

Add support for custom "Wait for Approval" instructions
ClosedPublic

Authored by epriestley on May 3 2019, 3:29 PM.
Tags
None
Referenced Files
F14127095: D20492.diff
Sat, Nov 30, 7:18 PM
Unknown Object (File)
Fri, Nov 29, 2:02 PM
Unknown Object (File)
Wed, Nov 20, 11:25 PM
Unknown Object (File)
Sun, Nov 17, 1:25 AM
Unknown Object (File)
Oct 29 2024, 11:37 AM
Unknown Object (File)
Oct 20 2024, 1:25 PM
Unknown Object (File)
Oct 18 2024, 1:09 AM
Unknown Object (File)
Sep 4 2024, 7:47 AM
Subscribers
Tokens
"Love" token, awarded by kylec.

Details

Reviewers
amckinley
Summary

See PHI1229. An install has a somewhat duct-taped registration flow which can dump users on the "Wait for Approval" screen without clear guidance. The desired guidance is something like "this is totally normal, just wait a bit for a bot to approve you".

Adding guidance here is generally reasonable and consistent with the intent of this feature.

Test Plan

Screen Shot 2019-05-03 at 8.26.17 AM.png (765×1 px, 144 KB)

Diff Detail

Repository
rP Phabricator
Branch
instructions1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22757
Build 31202: Run Core Tests
Build 31201: arc lint + arc unit

Event Timeline

And, obviously, fixing the flow to just work would be ideal, but that's like a thousand miles away through the swamps of T5953, and maybe not even then in this case (where part of the issue was using provider X as an authority, and provider Y as an actual login provider).

This revision is now accepted and ready to land.May 16 2019, 1:01 PM