Page MenuHomePhabricator

Make very minor generality improvements to the scope selector
ClosedPublic

Authored by epriestley on Apr 25 2019, 10:31 PM.
Tags
None
Referenced Files
F13145562: D20479.diff
Fri, May 3, 9:10 AM
Unknown Object (File)
Tue, Apr 30, 2:15 PM
Unknown Object (File)
Thu, Apr 25, 4:39 AM
Unknown Object (File)
Thu, Apr 25, 2:48 AM
Unknown Object (File)
Thu, Apr 11, 10:05 AM
Unknown Object (File)
Thu, Apr 4, 4:05 PM
Unknown Object (File)
Apr 2 2024, 11:06 PM
Unknown Object (File)
Apr 1 2024, 4:50 AM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI985. I think we pretty much need to start applying language-specific rules, but we can apply at least one more relatively language-agnostic rule: don't match lines which are indented 3+ levels.

In C++, we may have symbols like this:

class X {
  public:
    int m() { ... }
}

..but I believe no mainstream language puts symbol definitions 3+ levels deep.

Also clean up some of the tab handling very slightly.

Test Plan

Tests pass, looked at some C++ code and got slightly better (but still not great) matches.

Diff Detail

Repository
rP Phabricator
Branch
scope1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/PhabricatorDiffScopeEngine.php:119XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 22726
Build 31154: Run Core Tests
Build 31153: arc lint + arc unit