Paths

Table of Contentst

Differential D20386

Support "JIRA Issue URIs" as a Herald field for revisions
ClosedPublic
Actions

Authored by epriestley on Apr 10 2019, 4:14 PM.

Details

Reviewers

amckinley

Commits

rP9e65e6c50342: Support "JIRA Issue URIs" as a Herald field for revisions

Summary

See PHI1175. An install would like to trigger some reminders/guidance if users don't link revisions to JIRA issues.

Expose "JIRA Issue URIs" as a field so Herald can act on the presence or absence of issues.

I'm exposing "JIRA Issue URIs", not a field like "[ Has Jira Issue ][ is true ]", since it's a bit more flexible: you can use a regexp to test against particular PROJ-123 project prefixes in JIRA, for example.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

jira1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22524
Build 30839: Run Core Tests
Build 30838: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2019, 4:14 PM

Harbormaster completed remote builds in B22524: Diff 48649.Apr 10 2019, 4:15 PM

epriestley requested review of this revision.Apr 10 2019, 4:15 PM

amckinley accepted this revision.Apr 10 2019, 5:32 PM

This revision is now accepted and ready to land.Apr 10 2019, 5:32 PM

epriestley added inline comments.Apr 10 2019, 5:32 PM

src/applications/differential/herald/DifferentialRevisionJIRAIssueURIsHeraldField.php
27	(This edge is kind of named backwards, but this is the correct half of it to query for.)

Closed by commit rP9e65e6c50342: Support "JIRA Issue URIs" as a Herald field for revisions (authored by epriestley). · Explain WhyApr 10 2019, 6:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

differential/

herald/

DifferentialRevisionJIRAIssueURIsHeraldField.php

44 lines

Diff 48649

View Options

src/__phutil_library_map__.php