Differential D20326

When changing the trigger type in the trigger editor, properly redraw the control
ClosedPublic
Actions

Authored by epriestley on Mar 26 2019, 6:47 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13269: Improve initial implementations of Workboard triggers and groups

Commits

rPf6658bf391d3: When changing the trigger type in the trigger editor, properly redraw the…

Summary

Ref T13269. I refactored this late in the game to organize things better and add table cells around stuff, and accidentally broke the relationship between the "Rule Type" selector and the value selector.

Test Plan

Switched rule type selector from "Change Status" to "Play Sound", saw secondary control update properly.

Diff Detail

Repository

rP Phabricator

Branch

trigger1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22387
Build 30626: Run Core Tests
Build 30625: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 26 2019, 6:47 PM

Harbormaster completed remote builds in B22387: Diff 48516.Mar 26 2019, 6:48 PM

epriestley requested review of this revision.Mar 26 2019, 6:48 PM

amckinley accepted this revision.Mar 26 2019, 6:50 PM

This revision is now accepted and ready to land.Mar 26 2019, 6:50 PM

Closed by commit rPf6658bf391d3: When changing the trigger type in the trigger editor, properly redraw the… (authored by epriestley). · Explain WhyMar 26 2019, 6:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

trigger/

TriggerRule.js

8 lines

Diff 48516

View Options

resources/celerity/map.php