Differential D20307

Explain the relationship between "Runnable" and "Restartable" more clearly in Build Plans
ClosedPublic
Actions

Authored by epriestley on Mar 22 2019, 1:43 PM.

Tags

None

Referenced Files

	F14103650: D20307.diff
	Tue, Nov 26, 10:21 PM

	F14101071: D20307.id48482.diff
	Tue, Nov 26, 3:46 PM

	F14101070: D20307.id48461.diff
	Tue, Nov 26, 3:46 PM

	F14101069: D20307.id.diff
	Tue, Nov 26, 3:46 PM

	Unknown Object (File)
	Wed, Nov 20, 8:48 AM

	Unknown Object (File)
	Oct 21 2024, 11:36 PM

	Unknown Object (File)
	Oct 21 2024, 10:35 PM

	Unknown Object (File)
	Oct 20 2024, 6:10 AM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers

amckinley

Commits

rP79e36dc7fa39: Explain the relationship between "Runnable" and "Restartable" more clearly in…

Summary

See PHI1153. The "Runnable" and "Restartable" behaviors interact (to click "restart", you must be able to run the build AND it must be restartable). Make this more clear.

Test Plan

Screen Shot 2019-03-22 at 6.41.05 AM.png (600×839 px, 85 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 22 2019, 1:43 PM

Owners added a subscriber: Restricted Owners Package.Mar 22 2019, 1:43 PM

Harbormaster completed remote builds in B22325: Diff 48461.Mar 22 2019, 1:44 PM

epriestley requested review of this revision.Mar 22 2019, 1:44 PM

amckinley accepted this revision.Mar 25 2019, 6:00 PM

This revision is now accepted and ready to land.Mar 25 2019, 6:00 PM

Closed by commit rP79e36dc7fa39: Explain the relationship between "Runnable" and "Restartable" more clearly in… (authored by epriestley). · Explain WhyMar 25 2019, 6:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

plan/

HarbormasterBuildPlanBehavior.php

18 lines

Diff 48482

View Options

src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php

Explain the relationship between "Runnable" and "Restartable" more clearly in Build PlansClosedPublicActions