Page MenuHomePhabricator
Differential D20303

Show a trigger rule summary on the rule view page
ClosedPublic
Actions

Authored by epriestley on Mar 21 2019, 7:30 PM.
Tags
None
Referenced Files
F13275977: D20303.diff
Fri, May 31, 5:25 AM
F13265537: D20303.id.diff
Tue, May 28, 5:12 AM
F13262435: D20303.diff
Mon, May 27, 2:08 AM
F13245457: D20303.diff
Thu, May 23, 6:02 AM
F13240924: D20303.id48501.diff
Wed, May 22, 5:53 PM
F13223492: D20303.diff
Sun, May 19, 4:40 AM
F13205729: D20303.diff
Wed, May 15, 2:19 AM
F13189901: D20303.diff
Sat, May 11, 6:32 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T5474: Support workboard column triggers which activate when a task is dropped into a column
Commits
rP614f39b80679: Show a trigger rule summary on the rule view page
Summary

Ref T5474. When you view the main page for a rule, show what the rule does before you actually edit it.

Test Plan

Viewed a real trigger, then faked invalid/unknown rules:

Screen Shot 2019-03-21 at 12.20.39 PM.png (228×1 px, 35 KB)

Screen Shot 2019-03-21 at 12.25.51 PM.png (230×1 px, 42 KB)

Screen Shot 2019-03-21 at 12.27.04 PM.png (239×1 px, 48 KB)

Diff Detail

Repository
rP Phabricator
Branch
trigger9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22321
Build 30534: Run Core Tests
Build 30533: arc lint + arc unit

Revision Contents
Changeset List

Diff 48457

View Options

src/applications/project/controller/trigger/PhabricatorProjectTriggerViewController.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTrigger.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerInvalidRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerStatusRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerUnknownRule.php

Loading...
Phabricator · Built by Phacility