Page MenuHomePhabricator
Differential D20295

Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer
ClosedPublic
Actions

Authored by epriestley on Mar 18 2019, 9:52 PM.
Tags
None
Referenced Files
F15528945: D20295.id48437.diff
Tue, Apr 22, 3:21 PM
F15524463: D20295.id48449.diff
Mon, Apr 21, 8:10 AM
F15511110: D20295.diff
Wed, Apr 16, 11:58 PM
F15509868: D20295.id.diff
Wed, Apr 16, 4:48 PM
F15507863: D20295.diff
Tue, Apr 15, 11:34 PM
F15487443: D20295.id48449.diff
Thu, Apr 10, 2:06 PM
F15481090: D20295.id.diff
Tue, Apr 8, 6:06 PM
F15479228: D20295.diff
Tue, Apr 8, 5:34 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery"
Commits
rP3940c8e1f43a: Make the UI when you use an invalid cursor ("?after=19874189471232892") a…
Summary

Ref T13259. Currently, visiting a page that executes a query with an invalid cursor raises a bare exception that escapes to top level.

Catch this a little sooner and tailor the page a bit.

Test Plan

Visited /maniphest/?after=335234234223, saw a nicer exception page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 48449

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/infrastructure/query/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorInvalidQueryCursorException.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility