Page MenuHomePhabricator
Differential D20295

Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer
ClosedPublic
Actions

Authored by epriestley on Mar 18 2019, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:10 AM
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Wed, Apr 3, 6:44 PM
Unknown Object (File)
Wed, Apr 3, 6:44 PM
Unknown Object (File)
Wed, Apr 3, 6:44 PM
Unknown Object (File)
Wed, Apr 3, 6:44 PM
Unknown Object (File)
Mar 29 2024, 10:30 AM
Unknown Object (File)
Feb 14 2024, 6:58 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery"
Commits
rP3940c8e1f43a: Make the UI when you use an invalid cursor ("?after=19874189471232892") a…
Summary

Ref T13259. Currently, visiting a page that executes a query with an invalid cursor raises a bare exception that escapes to top level.

Catch this a little sooner and tailor the page a bit.

Test Plan

Visited /maniphest/?after=335234234223, saw a nicer exception page.

Diff Detail

Repository
rP Phabricator
Branch
cursor5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22302
Build 30504: Run Core Tests
Build 30503: arc lint + arc unit

Revision Contents
Changeset List

Diff 48437

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/infrastructure/query/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorEmptyQueryException.php

Loading...
View Options

src/infrastructure/query/exception/PhabricatorInvalidQueryCursorException.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility