Index "Call Webhook" in Herald, and show calling rules on the Webhook page
ClosedPublic
Actions

Authored by epriestley on Mar 7 2019, 2:37 PM.

Details

Reviewers

amckinley

Commits

rP1d4f6bd44458: Index "Call Webhook" in Herald, and show calling rules on the Webhook page

Summary

Depends on D20259. Now that we can index Herald rules to affected objects, show callers on the "Webhooks" UI.

A few other rule types could get indexes too ("Sign Legalpad Documents", "Add Reviewers", "Add Subscribers"), but I think they're less likely to be useful since those triggers are usually more obvious (the transaction timeline makes it clearer what happened/why). We could revisit this in the future now that it's a possibility.

Test Plan

Screen Shot 2019-03-07 at 6.34.26 AM.png (444×698 px, 32 KB)

Diff Detail

Repository

rP Phabricator

Branch

unlock5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22230
Build 30395: Run Core Tests
Build 30394: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2019, 2:37 PM

Harbormaster completed remote builds in B22211: Diff 48352.Mar 7 2019, 2:39 PM

epriestley requested review of this revision.Mar 7 2019, 2:39 PM

Push fixes for null/empty behavior back to the previous revision.

Harbormaster completed remote builds in B22213: Diff 48354.Mar 7 2019, 3:26 PM

amckinley accepted this revision.Mar 7 2019, 10:12 PM

amckinley added inline comments.

src/applications/herald/controller/HeraldWebhookViewController.php
215	"called"?

This revision is now accepted and ready to land.Mar 7 2019, 10:12 PM

epriestley added inline comments.Mar 7 2019, 10:19 PM

src/applications/herald/controller/HeraldWebhookViewController.php
207	Oh, I'll stick like a `setLimit(10)` here and on the similar one in BuildPlan before I land this. I doubt anyone is going to write 19,000 herald rules to run a particular plan or call a particular hook, but no sense in breaking the page if they get super creative.
215	This is a list of Rules which have a "Call Webhook: ..." action -- they may not have actually fired yet. Although you're probably using this panel to answer a question like "Which rule is calling / just called this hook?", it could also answer a question like "I'm pretty sure I wrote a rule for this but the hook isn't being called, which rule did I write?".