Differential D20244

Clean up a few "%Q" stragglers in SVN repository browsing code
ClosedPublic
Actions

Authored by epriestley on Mar 2 2019, 2:16 PM.

Details

Reviewers

amckinley

Commits

rP34e90d8f5139: Clean up a few "%Q" stragglers in SVN repository browsing code

Summary

See https://discourse.phabricator-community.org/t/unsafe-raw-string-warning-for-svn-in-diffusion/2469.

Test Plan

Browed a Subversion repository in Diffusion. These are all reachable from the main landing page if the repository has commits/files, I think. Before change: errors in log; after change: no issues.

Diff Detail

Repository

rP Phabricator

Branch

sql1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22172
Build 30306: Run Core Tests
Build 30305: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 2 2019, 2:16 PM

Harbormaster completed remote builds in B22172: Diff 48311.Mar 2 2019, 2:18 PM

epriestley requested review of this revision.Mar 2 2019, 2:18 PM

amckinley accepted this revision.Mar 5 2019, 5:10 PM

This revision is now accepted and ready to land.Mar 5 2019, 5:10 PM

Closed by commit rP34e90d8f5139: Clean up a few "%Q" stragglers in SVN repository browsing code (authored by epriestley). · Explain WhyMar 5 2019, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionBrowseQueryConduitAPIMethod.php

12 lines

DiffusionHistoryQueryConduitAPIMethod.php

12 lines

Diff 48311

View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php