Differential D20222

Clean up a PhutilURI "alter()" callsite in Diffusion blame
ClosedPublic
Actions

Authored by epriestley on Feb 28 2019, 1:45 PM.

Tags

None

Referenced Files

	F21692955: D20222.id48273.diff
	Fri, Aug 7, 12:09 PM

	Unknown Object (File)
	Jul 4 2026, 11:18 AM

	Unknown Object (File)
	Jun 20 2026, 1:41 AM

	Unknown Object (File)
	Jun 5 2026, 2:52 AM

	Unknown Object (File)
	Apr 17 2026, 8:34 PM

	Unknown Object (File)
	Apr 2 2026, 12:05 AM

	Unknown Object (File)
	Mar 30 2026, 2:43 AM

	Unknown Object (File)
	Mar 29 2026, 4:15 AM

View All Files

Subscribers

None

Tokens

"Like" token, awarded by NDKilla.

Details

Reviewers

amckinley

Commits

rP4cc556b576ab: Clean up a PhutilURI "alter()" callsite in Diffusion blame

Summary

See https://discourse.phabricator-community.org/t/exception-when-viewing-previous-revision-from-blame/2454/2.

Test Plan

Viewed blame, clicked "Skip Past This Commit". Got jumped to the right place instead of a URI exception.

Diff Detail

Repository

rP Phabricator

Branch

urix1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22135
Build 30247: Run Core Tests
Build 30246: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 28 2019, 1:45 PM

Harbormaster completed remote builds in B22135: Diff 48273.Feb 28 2019, 1:46 PM

epriestley requested review of this revision.Feb 28 2019, 1:47 PM

NDKilla awarded a token.Feb 28 2019, 2:54 PM

amckinley accepted this revision.Mar 1 2019, 12:17 AM

This revision is now accepted and ready to land.Mar 1 2019, 12:17 AM

Closed by commit rP4cc556b576ab: Clean up a PhutilURI "alter()" callsite in Diffusion blame (authored by epriestley). · Explain WhyMar 1 2019, 3:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

13 lines

Diff 48273

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Clean up a PhutilURI "alter()" callsite in Diffusion blameClosedPublicActions