Page MenuHomePhabricator
Differential D20222

Clean up a PhutilURI "alter()" callsite in Diffusion blame
ClosedPublic
Actions

Authored by epriestley on Feb 28 2019, 1:45 PM.
Tags
None
Referenced Files
F14806493: D20222.id48296.diff
Sun, Jan 26, 2:57 AM
Unknown Object (File)
Sat, Jan 25, 3:57 AM
Unknown Object (File)
Sat, Jan 25, 3:57 AM
Unknown Object (File)
Sat, Jan 25, 3:57 AM
Unknown Object (File)
Wed, Jan 22, 5:11 PM
Unknown Object (File)
Tue, Jan 21, 12:32 PM
Unknown Object (File)
Tue, Jan 21, 10:04 AM
Unknown Object (File)
Sun, Jan 12, 11:10 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by NDKilla.

Details

Reviewers
amckinley
Commits
rP4cc556b576ab: Clean up a PhutilURI "alter()" callsite in Diffusion blame
Summary

See https://discourse.phabricator-community.org/t/exception-when-viewing-previous-revision-from-blame/2454/2.

Test Plan

Viewed blame, clicked "Skip Past This Commit". Got jumped to the right place instead of a URI exception.

Diff Detail

Repository
rP Phabricator
Branch
urix1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22135
Build 30247: Run Core Tests
Build 30246: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
13 lines

Diff 48273

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility