Differential D20212

Fix a stray "%Q" warning when hiding/showing inline comments
ClosedPublic
Actions

Authored by epriestley on Feb 25 2019, 8:43 PM.

Tags

None

Referenced Files

	F13260001: D20212.diff
	Sun, May 26, 11:22 PM

	F13244219: D20212.diff
	Thu, May 23, 4:37 AM

	F13225698: D20212.id48260.diff
	Sun, May 19, 4:52 PM

	F13219499: D20212.id48261.diff
	Sat, May 18, 6:58 PM

	F13206603: D20212.diff
	Wed, May 15, 1:01 PM

	F13192223: D20212.diff
	Sun, May 12, 6:23 AM

	F13173981: D20212.diff
	Tue, May 7, 9:32 PM

	Unknown Object (File)
	Tue, May 7, 3:08 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPdc9aaa0fc2bf: Fix a stray "%Q" warning when hiding/showing inline comments

Summary

See PHI1095.

Test Plan

Viewed a revision, toggled hide/show on inline comments. Before: warning in logs; after: smooth sailing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 25 2019, 8:43 PM

Harbormaster completed remote builds in B22122: Diff 48260.Feb 25 2019, 8:44 PM

epriestley requested review of this revision.Feb 25 2019, 8:44 PM

amckinley accepted this revision.Feb 25 2019, 9:45 PM

This revision is now accepted and ready to land.Feb 25 2019, 9:45 PM

Closed by commit rPdc9aaa0fc2bf: Fix a stray "%Q" warning when hiding/showing inline comments (authored by epriestley). · Explain WhyFeb 25 2019, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialInlineCommentEditController.php

4 lines

Diff 48261

View Options

src/applications/differential/controller/DifferentialInlineCommentEditController.php

Fix a stray "%Q" warning when hiding/showing inline commentsClosedPublicActions