Fixes T13254. See that task for details.
Details
Details
Used iOS Simulator to do a login locally, didn't get blocked. Verified CSP includes "m.facebook.com".
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/applications/auth/provider/PhabricatorFacebookAuthProvider.php | ||
---|---|---|
117–127 | Is this just incidentally dead code you're removing? |
src/applications/auth/provider/PhabricatorFacebookAuthProvider.php | ||
---|---|---|
117–127 | Yeah it looks dead to me and grep. |
Comment Actions
Yeah, sorry, no callsites per grep. And probably won't work without changes in a T6703 world anyway, since there might plausibly be multiple Facebook auth providers.