Paths

Table of Contentst

Differential D20186

Fix a couple more "URI->alter()" callsites in paging code
ClosedPublicDraft
Actions

Authored by epriestley on Feb 16 2019, 3:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 4:03 AM

	Unknown Object (File)
	Fri, Apr 19, 9:08 AM

	Unknown Object (File)
	Fri, Apr 19, 4:23 AM

	Unknown Object (File)
	Tue, Apr 16, 5:05 PM

	Unknown Object (File)
	Tue, Apr 16, 5:03 PM

	Unknown Object (File)
	Tue, Apr 16, 5:03 PM

	Unknown Object (File)
	Tue, Apr 16, 5:03 PM

	Unknown Object (File)
	Wed, Apr 10, 5:52 PM

View All 89 Files

Subscribers

None

Details

Reviewers

Commits

rP005eb5f9fcec: (stable) Fix a couple more "URI->alter()" callsites in paging code
rPdbcf41dbea00: Fix a couple more "URI->alter()" callsites in paging code

Summary

grep had a hard time finding these.

Test Plan

Will just hotfix this since I'm still reasonably in the deploy window, this currently fatals: https://secure.phabricator.com/search/query/_dgatshiRBSy/#R

Diff Detail

Repository

Branch

pager1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22040
Build 30108: Run Core Tests
Build 30107: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	50 ms	DifferentialParseRenderTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at DifferentialParseRenderTestCase.php:56): generated.diff.one.unshielded Expected vs Actual Output Diff --- Old Value
	1 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 6 assertions passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 4 assertions passed.
		View Full Test Results (1 Failed · 374 Passed)

Event Timeline

epriestley created this revision.Feb 16 2019, 3:27 PM

This revision was not accepted when it landed; it landed in state Draft.Feb 16 2019, 3:28 PM

Closed by commit rPdbcf41dbea00: Fix a couple more "URI->alter()" callsites in paging code (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B22040: Diff 48193!Feb 16 2019, 3:30 PM

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIPagerView.php

23 lines

Diff 48193

src/view/phui/PHUIPagerView.php

Loading...