Page MenuHomePhabricator

Fix a couple more "URI->alter()" callsites in paging code
ClosedPublicDraft

Authored by epriestley on Feb 16 2019, 3:27 PM.
Tags
None
Referenced Files
F14417629: D20186.id48194.diff
Wed, Dec 25, 1:56 AM
F14413348: D20186.diff
Tue, Dec 24, 2:08 PM
Unknown Object (File)
Fri, Dec 13, 8:29 AM
Unknown Object (File)
Nov 5 2024, 12:41 AM
Unknown Object (File)
Oct 29 2024, 4:33 PM
Unknown Object (File)
Oct 21 2024, 8:11 AM
Unknown Object (File)
Sep 27 2024, 11:26 PM
Unknown Object (File)
Sep 27 2024, 11:26 PM
Subscribers
None

Details

Summary

grep had a hard time finding these.

Test Plan

Will just hotfix this since I'm still reasonably in the deploy window, this currently fatals: https://secure.phabricator.com/search/query/_dgatshiRBSy/#R

Diff Detail

Repository
rP Phabricator
Branch
pager1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22040
Build 30108: Run Core Tests
Build 30107: arc lint + arc unit

Unit TestsFailed

TimeTest
50 msDifferentialParseRenderTestCase::Unknown Unit Message ("")
Assertion failed, expected values to be equal (at DifferentialParseRenderTestCase.php:56): generated.diff.one.unshielded Expected vs Actual Output Diff --- Old Value
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
6 assertions passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
4 assertions passed.
View Full Test Results (1 Failed · 374 Passed)

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Feb 16 2019, 3:28 PM
This revision was automatically updated to reflect the committed changes.