Page MenuHomePhabricator
Differential D20157

Fix specifications of some "Visual Only" elements
ClosedPublic
Actions

Authored by epriestley on Feb 13 2019, 12:40 PM.
Tags
None
Referenced Files
F13207375: D20157.id.diff
Wed, May 15, 10:38 PM
F13204339: D20157.diff
Wed, May 15, 12:29 AM
F13187234: D20157.diff
Sat, May 11, 4:24 AM
Unknown Object (File)
Tue, May 7, 7:32 AM
Unknown Object (File)
Fri, May 3, 6:41 AM
Unknown Object (File)
Wed, May 1, 10:53 PM
Unknown Object (File)
Thu, Apr 25, 1:15 AM
Unknown Object (File)
Sun, Apr 21, 12:24 PM
View All 96 Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP88d5233b7776: Fix specifications of some "Visual Only" elements
Summary

See PHI823. These got "visual-only" but should acutally get "aural => false" to pick up "aria-hidden".

Test Plan

Viewed page source, saw both "visual-only" and "aria-hidden".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
view/
5 lines
view/
phui/
5 lines
5 lines

Diff 48145

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/view/phui/PHUIHeadThingView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility