Differential D20155

Update "setQueryParam[s]()" calls in libphutil
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 10:35 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rPHU650bdfa65f2f: (stable) Promote 2019 Week 7
rPHUda84d9c24445: Update "setQueryParam[s]()" calls in libphutil

Summary

Ref T13250. See D20149.

Test Plan

Lightly tested Google, AWS. Mostly inspection since it's hard to hit all of these. These are largely mechanical.

Diff Detail

Repository

rPHU libphutil

Branch

uri6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21967
Build 30003: Run Core Tests
Build 30002: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2019, 10:35 PM

Harbormaster completed remote builds in B21967: Diff 48123.Feb 12 2019, 10:36 PM

epriestley requested review of this revision.Feb 12 2019, 10:36 PM

amckinley accepted this revision.Feb 14 2019, 7:45 PM

This revision is now accepted and ready to land.Feb 14 2019, 7:45 PM

Closed by commit rPHUda84d9c24445: Update "setQueryParam[s]()" calls in libphutil (authored by epriestley). · Explain WhyFeb 14 2019, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

auth/

PhutilAmazonAuthAdapter.php

2 lines

PhutilDisqusAuthAdapter.php

4 lines

PhutilFacebookAuthAdapter.php

4 lines

PhutilGitHubAuthAdapter.php

2 lines

PhutilGoogleAuthAdapter.php

4 lines

PhutilJIRAAuthAdapter.php

12 lines

PhutilOAuth1AuthAdapter.php

2 lines

PhutilOAuthAuthAdapter.php

10 lines

PhutilPhabricatorAuthAdapter.php

2 lines

PhutilTwitterAuthAdapter.php

12 lines

future/

aws/

PhutilAWSFuture.php

5 lines

oauth/

PhutilOAuth1Future.php

2 lines

slack/

PhutilSlackFuture.php

2 lines

twitch/

PhutilTwitchFuture.php

2 lines

Diff 48123

View Options

src/auth/PhutilAmazonAuthAdapter.php

View Options

src/auth/PhutilDisqusAuthAdapter.php

View Options

src/auth/PhutilFacebookAuthAdapter.php

View Options

src/auth/PhutilGitHubAuthAdapter.php

View Options

src/auth/PhutilGoogleAuthAdapter.php

View Options

src/auth/PhutilJIRAAuthAdapter.php

View Options

src/auth/PhutilOAuth1AuthAdapter.php

View Options

src/auth/PhutilOAuthAuthAdapter.php

View Options

src/auth/PhutilPhabricatorAuthAdapter.php

View Options

src/auth/PhutilTwitterAuthAdapter.php

View Options

src/future/aws/PhutilAWSFuture.php

View Options

src/future/oauth/PhutilOAuth1Future.php

View Options

src/future/slack/PhutilSlackFuture.php

View Options

src/future/twitch/PhutilTwitchFuture.php

Update "setQueryParam[s]()" calls in libphutilClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48123

src/auth/PhutilAmazonAuthAdapter.php

src/auth/PhutilDisqusAuthAdapter.php

src/auth/PhutilFacebookAuthAdapter.php

src/auth/PhutilGitHubAuthAdapter.php

src/auth/PhutilGoogleAuthAdapter.php

src/auth/PhutilJIRAAuthAdapter.php

src/auth/PhutilOAuth1AuthAdapter.php

src/auth/PhutilOAuthAuthAdapter.php

src/auth/PhutilPhabricatorAuthAdapter.php

src/auth/PhutilTwitterAuthAdapter.php

src/future/aws/PhutilAWSFuture.php

src/future/oauth/PhutilOAuth1Future.php

src/future/slack/PhutilSlackFuture.php

src/future/twitch/PhutilTwitchFuture.php

Update "setQueryParam[s]()" calls in libphutil
ClosedPublic
Actions

Revision Contents
Changeset List