Page MenuHomePhabricator

Allow administrators to provide custom welcome text when welcoming users on the profile workflow
ClosedPublic

Authored by epriestley on Jan 17 2019, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:11 PM
Unknown Object (File)
Mon, Dec 2, 1:42 AM
Unknown Object (File)
Thu, Nov 28, 3:04 AM
Unknown Object (File)
Nov 24 2024, 1:33 PM
Unknown Object (File)
Nov 20 2024, 10:17 PM
Unknown Object (File)
Nov 11 2024, 3:44 AM
Unknown Object (File)
Nov 10 2024, 4:23 PM
Unknown Object (File)
Nov 10 2024, 5:28 AM
Subscribers
None

Details

Summary

See PHI1027. Currently, we allow you to customize invite email, but not most other types of email (approve, welcome). As a step forward, also allow welcome email to be customized with a message.

I considered separating the custom text from the main text with something heavyhanded ("alice added this custom message:") or a beautiful ASCII art divider like one of these:

https://www.asciiart.eu/art-and-design/dividers

...but nothing truly sung to me.

This only works on the profile flow for now. I'm planning to let you set a default message. I may or may not let you customize from "Create New User", seems like the default message probably covers most of that. Probably won't touch scripts/user/add_user.php since that's not really exactly super supported.

Test Plan

Sent mail with and without custom messages, reviewed it with bin/mail show-outbound.

Screen Shot 2019-01-17 at 10.22.55 AM.png (624×1 px, 106 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley added inline comments.
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
158–191

This just cleans up the action menu a little bit, it's a change from the "Banish" diff that I liked even though I'm no longer very excited about "Banish". Visible in the background of the screenshot.

epriestley edited the summary of this revision. (Show Details)
amckinley added inline comments.
src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php
103–105

I don't really care either way, but I wanted to make sure the intention was to suppress our feelings of love if there's a custom message.

This revision is now accepted and ready to land.Jan 17 2019, 9:47 PM
src/applications/people/mail/PhabricatorPeopleWelcomeMailEngine.php
103–105

Yeah, it seemed like the signature bit might be a little weird with some custom text, e.g.

...

Thanks,
Evan

Love,
Phabricator