Page MenuHomePhabricator

When password auth is not enabled, don't tell users to set a password in welcome email
ClosedPublic

Authored by epriestley on Jan 17 2019, 6:06 PM.
Tags
None
Referenced Files
F15505880: D19990.id47724.diff
Tue, Apr 15, 6:42 AM
F15504089: D19990.id.diff
Mon, Apr 14, 3:42 PM
F15495144: D19990.diff
Sun, Apr 13, 2:57 AM
F15425818: D19990.id47749.diff
Sun, Mar 23, 6:16 AM
F15333258: D19990.diff
Mar 8 2025, 1:21 AM
Unknown Object (File)
Mar 3 2025, 6:45 PM
Unknown Object (File)
Jan 31 2025, 8:09 AM
Unknown Object (File)
Jan 21 2025, 9:40 AM
Subscribers
None

Details

Summary

See PHI1027. Currently, the "Welcome" mail always tells users to set a password. This definitely isn't helpful if an install doesn't have password auth enabled.

We can't necessarily guess what they're supposed to do, so just give them generic instructions ("set up your account"). Upcoming changes will give administrators more control over the mail content.

Test Plan

Sent both versions of the mail, used bin/mail show-outbound to inspect them for correctness.

Diff Detail

Repository
rP Phabricator
Branch
welcome2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21576
Build 29407: Run Core Tests
Build 29406: arc lint + arc unit