Update Mailgun adapter for the new mail adapter API
ClosedPublic
Actions

Authored by epriestley on Jan 5 2019, 12:59 PM.

Details

Reviewers

Maniphest Tasks

Commits

Summary

Ref T920. Ref T5969. Update the Mailgun adapter for the API changes and add a timeout.

Test Plan

Configured Mailgun as a mailer, sent mail with subject/to/cc/headers/html/attachments using bin/mail send-test.

Repository

rP Phabricator

Branch

mfa7

Lint

Lint Passed

Unit

Tests Passed

Build Status

epriestley requested review of this revision.Jan 5 2019, 1:01 PM

amckinley added inline comments.

src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43	Shouldn't this be `if (strlen($subject))`?
77	Unused variable.
85	Another `strlen`?
90	Another `strlen`?

This revision is now accepted and ready to land.Jan 10 2019, 4:32 PM

src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php
43	As currently written, `setSubject('')` will generate a `Subject:` header, which seems more faithful to intent than `strlen()`. I think this is probably moot in practice and (below) sending a mail with (say) an empty-but-present text body is probably weird/a mistake, but it's technically a valid construction. If there's ambiguity in practice, I think it's likely better resolved at a higher level (during message construction, e.g.)