Page MenuHomePhabricator

Consolidate some application email receiver code in preparation for API changes
ClosedPublic

Authored by epriestley on Jan 3 2019, 5:56 PM.
Tags
None
Referenced Files
F13296298: D19950.id47622.diff
Thu, Jun 6, 2:01 PM
F13278551: D19950.diff
Fri, May 31, 10:41 PM
F13257348: D19950.id47622.diff
Sat, May 25, 11:29 PM
F13250956: D19950.id47644.diff
Fri, May 24, 6:48 PM
F13250888: D19950.id.diff
Fri, May 24, 6:14 PM
F13233715: D19950.diff
Tue, May 21, 2:31 AM
F13227296: D19950.diff
Mon, May 20, 2:26 AM
F13219817: D19950.diff
Sat, May 18, 9:03 PM
Subscribers
None

Details

Summary

Ref T7477. The various "create a new X via email" applications (Paste, Differential, Maniphest, etc) all have a bunch of duplicate code.

The inheritance stack here is generally a little weird. Extend these from a shared parent to reduce the number of callsites I need to change when this API is adjusted for T7477.

Test Plan

Ran unit tests. This will get more thorough testing once more pieces are in place.

Diff Detail

Repository
rP Phabricator
Branch
mfa10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21475
Build 29252: Run Core Tests
Build 29251: arc lint + arc unit