Page MenuHomePhabricator

Extract some email address utility code from the receiver stack
ClosedPublic

Authored by epriestley on Jan 3 2019, 4:06 PM.
Tags
None
Referenced Files
F15336529: D19948.diff
Sat, Mar 8, 7:23 PM
Unknown Object (File)
Sun, Feb 9, 6:52 AM
Unknown Object (File)
Sun, Feb 9, 6:52 AM
Unknown Object (File)
Sun, Feb 9, 6:52 AM
Unknown Object (File)
Feb 7 2025, 12:48 PM
Unknown Object (File)
Feb 2 2025, 10:54 AM
Unknown Object (File)
Jan 26 2025, 5:09 PM
Unknown Object (File)
Jan 25 2025, 4:01 PM
Subscribers
None

Details

Summary

Ref T7477. We have some address normalization code in the reciever stack that is really shared code. I want to introduce some new callsites elsewhere but don't want to put a lot of static calls to other random objects all over the place.

This technically "solves" T7477 (it changes "to" to "to + cc" for finding receivers) but doesn't yet implement proper behavior (with multiple receivers, for example).

Test Plan

Ran unit tests, which cover this pretty well. Additional changes will vet this more thoroughly.

Diff Detail

Repository
rP Phabricator
Branch
mfa8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21473
Build 29248: Run Core Tests
Build 29247: arc lint + arc unit