Page MenuHomePhabricator

Remove old Phrequent propery rendering code and show "Time Spent" in higher precision
ClosedPublic

Authored by epriestley on Dec 22 2018, 11:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 9:09 PM
Unknown Object (File)
Sat, Dec 14, 3:34 PM
Unknown Object (File)
Fri, Dec 6, 4:55 AM
Unknown Object (File)
Tue, Dec 3, 12:18 PM
Unknown Object (File)
Sun, Dec 1, 5:27 PM
Unknown Object (File)
Mon, Nov 25, 11:54 AM
Unknown Object (File)
Nov 21 2024, 5:01 PM
Unknown Object (File)
Nov 16 2024, 5:09 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/how-to-get-total-time-spent-on-a-task-in-minutes-or-hours/2241.

Phrequent has two nearly-identical copies of its rendering code: one for old "property event" objects and one for newer "curtain" objects. In the upstream, both trackable object types (tasks and revisions) use curtains, so throw away the old code since it isn't reachable. Third-party trackable objects can update to the curtain UI, but it's unlikely they exist.

Render the remaining curtain UI with more precision, so we show "Time Spent: 2d, 11h, 49m" instead of "Time Spent: 2d".

Test Plan

Screen Shot 2018-12-22 at 3.54.11 AM.png (128×333 px, 7 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/phrequent/engineextension/PhrequentCurtainExtension.php
16

(This method is largely identical to the removed method, below. It renders into the newer "curtain" sidebar element; the old one rendered directly into the main column's list of properties.)

This revision is now accepted and ready to land.Dec 24 2018, 10:14 PM
This revision was automatically updated to reflect the committed changes.