Suppress an unhelpful Almanac transaction and document the location of the secret clustering management capability. I thought maybe implementing shouldHide and checking for isCreate would work, but the binding apparently gets created before an interface is bound to it.
Details
Details
- Reviewers
epriestley - Commits
- rPc72d29f401e2: Cleanup some clustering rough edges
Looked at a fresh binding and didn't see "Unknown Object(??)", ran bin/diviner and saw expected output.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21393 Build 29131: Run Core Tests Build 29130: arc lint + arc unit
Event Timeline
| src/applications/almanac/xaction/AlmanacBindingInterfaceTransaction.php | ||
|---|---|---|
| 59–62 | Some day, this transaction will be marked as TYPE_CREATE and hidden, but adding a better rendering to it is quite reasonable for now (and maybe we'll go back and add more of these if we let you render hidden transactions with transaction.search at some point). | |
| 63–66 | I think removing an interface is impossible so this code is unreachable. | |