Remove application callers to "LiskDAO->loadRelatives()"
ClosedPublic
Actions

Authored by epriestley on Dec 12 2018, 11:39 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13218: Remove LiskDAO->loadOneRelative()

Commits

rP5c99163b7c80: Remove application callers to "LiskDAO->loadRelatives()"

Summary

Ref T13218. See that task for some discussion. loadRelatives() is like loadAllWhere(...) except that it does enormous amounts of weird magic which we've moved away from.

Test Plan

Did not test whatsoever since these changes are in Releeph.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 12 2018, 11:39 PM

Harbormaster completed remote builds in B21313: Diff 47462.Dec 12 2018, 11:41 PM

epriestley requested review of this revision.Dec 12 2018, 11:41 PM

amckinley accepted this revision.Dec 12 2018, 11:54 PM

This revision is now accepted and ready to land.Dec 12 2018, 11:54 PM

Closed by commit rP5c99163b7c80: Remove application callers to "LiskDAO->loadRelatives()" (authored by epriestley). · Explain WhyDec 13 2018, 12:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

releeph/

conduit/

ReleephGetBranchesConduitAPIMethod.php

8 lines

field/

specification/

ReleephDiffSizeFieldSpecification.php

13 lines

Diff 47471

View Options

src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php