Page MenuHomePhabricator
Differential D19879

Completely remove "LiskDAOSet" and "loadRelatives/loadOneRelative"
ClosedPublic
Actions

Authored by epriestley on Dec 13 2018, 12:16 AM.
Tags
None
Referenced Files
F15421102: D19879.diff
Fri, Mar 21, 9:03 PM
F15375394: D19879.id.diff
Wed, Mar 12, 10:58 PM
F15331347: D19879.diff
Fri, Mar 7, 9:11 AM
Unknown Object (File)
Mon, Mar 3, 2:15 PM
Unknown Object (File)
Mon, Mar 3, 2:15 PM
Unknown Object (File)
Mon, Mar 3, 2:15 PM
Unknown Object (File)
Feb 9 2025, 6:46 AM
Unknown Object (File)
Feb 9 2025, 6:46 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13218: Remove LiskDAO->loadOneRelative()
Commits
rP9aa5a52fbd1b: Completely remove "LiskDAOSet" and "loadRelatives/loadOneRelative"
Summary

Fixes T13218. We have no more callers to any of this and can get rid of it forever.

Test Plan

Grepped for all four API methods, LiskDAOSet, and inSet.

Diff Detail

Repository
rP Phabricator
Branch
relative4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21321
Build 29013: Run Core Tests
Build 29012: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
lisk/
170 lines

Diff 47470

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAOSet.php

Loading...
Phabricator · Built by Phacility