Paths

Table of Contentst

Differential D19876

Remove application callsites to "LiskDAO->loadOneRelative()"
ClosedPublic
Actions

Authored by epriestley on Dec 12 2018, 11:49 PM.

Tags

None

Referenced Files

	F13188597: D19876.diff
	Sat, May 11, 5:21 AM

	Unknown Object (File)
	Tue, May 7, 8:36 AM

	Unknown Object (File)
	Mon, May 6, 5:13 AM

	Unknown Object (File)
	Fri, May 3, 6:15 PM

	Unknown Object (File)
	Fri, May 3, 8:38 AM

	Unknown Object (File)
	Thu, Apr 25, 2:28 AM

	Unknown Object (File)
	Fri, Apr 19, 2:44 PM

	Unknown Object (File)
	Apr 18 2024, 12:36 AM

View All 98 Files

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T13218: Remove LiskDAO->loadOneRelative()

Commits

rP793f185d2924: Remove application callsites to "LiskDAO->loadOneRelative()"

Summary

Ref T13218. This is like loadOneWhere(...) but with more dark magic. Get rid of it.

Test Plan

Forced 20130219.commitsummarymig.php to hit this code and ran it with bin/storage upgrade --force --apply ....
Ran 20130409.commitdrev.php with bin/storage upgrade --force --apply ....
Called user.search to indirectly get primary email information.
Did not test Releeph at all.

Diff Detail

Repository

Branch

relative2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21315
Build 29002: Run Core Tests
Build 29001: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 12 2018, 11:49 PM

Owners added a subscriber: Restricted Owners Package.Dec 12 2018, 11:49 PM

Harbormaster completed remote builds in B21315: Diff 47464.Dec 12 2018, 11:51 PM

epriestley requested review of this revision.Dec 12 2018, 11:51 PM

amckinley accepted this revision.Dec 12 2018, 11:57 PM

This revision is now accepted and ready to land.Dec 12 2018, 11:57 PM

Closed by commit rP793f185d2924: Remove application callsites to "LiskDAO->loadOneRelative()" (authored by epriestley). · Explain WhyDec 13 2018, 12:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

patches/

20130219.commitsummarymig.php

6 lines

20130409.commitdrev.php

4 lines

src/

applications/

people/

storage/

PhabricatorUser.php

11 lines

releeph/

conduit/

ReleephGetBranchesConduitAPIMethod.php

7 lines

storage/

ReleephRequest.php

13 lines

Diff 47464

resources/sql/patches/20130219.commitsummarymig.php

Loading...

resources/sql/patches/20130409.commitdrev.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...

src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php

Loading...

src/applications/releeph/storage/ReleephRequest.php

Loading...