Differential D19871

Fix an issue with item list view icon labels (including Differential date updated times) not appearing in the UI
ClosedPublic
Actions

Authored by epriestley on Dec 12 2018, 5:31 PM.

Tags

None

Referenced Files

	F14412355: D19871.diff
	Tue, Dec 24, 12:56 PM

	Unknown Object (File)
	Mon, Dec 16, 4:49 AM

	Unknown Object (File)
	Mon, Dec 16, 4:49 AM

	Unknown Object (File)
	Mon, Dec 16, 4:49 AM

	Unknown Object (File)
	Mon, Dec 16, 4:49 AM

	Unknown Object (File)
	Fri, Dec 6, 9:01 AM

	Unknown Object (File)
	Tue, Nov 26, 5:31 AM

	Unknown Object (File)
	Mon, Nov 25, 2:06 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP265f1f9c4d8a: Fix an issue with item list view icon labels (including Differential date…

Summary

In D19855, I removed a no-longer-necessary link around icons in some cases, but incorrectly discarded labels in other cases. Restore labels.

Test Plan

Viewed Differential revision list, saw date stamps again.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 12 2018, 5:31 PM

epriestley mentioned this in D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.Dec 12 2018, 5:31 PM

Harbormaster completed remote builds in B21305: Diff 47452.Dec 12 2018, 5:32 PM

epriestley requested review of this revision.Dec 12 2018, 5:32 PM

amckinley accepted this revision.Dec 12 2018, 7:04 PM

This revision is now accepted and ready to land.Dec 12 2018, 7:04 PM

Closed by commit rP265f1f9c4d8a: Fix an issue with item list view icon labels (including Differential date… (authored by epriestley). · Explain WhyDec 12 2018, 7:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIObjectItemView.php

5 lines

Diff 47454

View Options

src/view/phui/PHUIObjectItemView.php

Fix an issue with item list view icon labels (including Differential date updated times) not appearing in the UIClosedPublicActions