Page MenuHomePhabricator
Differential D19871

Fix an issue with item list view icon labels (including Differential date updated times) not appearing in the UI
ClosedPublic
Actions

Authored by epriestley on Dec 12 2018, 5:31 PM.
Tags
None
Referenced Files
F15506049: D19871.id47454.diff
Tue, Apr 15, 8:12 AM
F15497811: D19871.id47452.diff
Sun, Apr 13, 11:14 AM
F15491903: D19871.id.diff
Sat, Apr 12, 8:47 AM
F15490382: D19871.diff
Fri, Apr 11, 4:49 PM
F15484922: D19871.diff
Wed, Apr 9, 9:01 PM
F15309025: D19871.id47454.diff
Mar 6 2025, 6:49 AM
F15309024: D19871.id47452.diff
Mar 6 2025, 6:49 AM
F15309023: D19871.id.diff
Mar 6 2025, 6:49 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP265f1f9c4d8a: Fix an issue with item list view icon labels (including Differential date…
Summary

In D19855, I removed a no-longer-necessary link around icons in some cases, but incorrectly discarded labels in other cases. Restore labels.

Test Plan

Viewed Differential revision list, saw date stamps again.

Diff Detail

Repository
rP Phabricator
Branch
icon1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21305
Build 28986: Run Core Tests
Build 28985: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
view/
phui/
5 lines

Diff 47452

View Options

src/view/phui/PHUIObjectItemView.php

Loading...
Phabricator · Built by Phacility