Differential D19844

Fix a transaction editor "continue;" inside "switch()" for PHP 7.3
ClosedPublic
Actions

Authored by epriestley on Dec 4 2018, 1:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 6:59 PM

	Unknown Object (File)
	Thu, May 2, 4:46 PM

	Unknown Object (File)
	Wed, May 1, 6:04 AM

	Unknown Object (File)
	Wed, May 1, 12:28 AM

	Unknown Object (File)
	Thu, Apr 25, 7:59 AM

	Unknown Object (File)
	Thu, Apr 11, 9:53 AM

	Unknown Object (File)
	Mar 31 2024, 9:01 PM

	Unknown Object (File)
	Mar 22 2024, 8:25 AM

View All 57 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP70bf63bc3adc: Fix a transaction editor "continue;" inside "switch()" for PHP 7.3

Summary

See https://discourse.phabricator-community.org/t/new-git-commit-processing-fails-on-php-7-3/. This "continue" should be a "break".

Test Plan

Screen Shot 2018-12-04 at 5.52.33 AM.png (264×453 px, 25 KB)

Tried to assign a task to myself while I was already the owner, got an appropriate error.

Diff Detail

Repository

rP Phabricator

Branch

continue1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21244
Build 28893: Run Core Tests
Build 28892: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 4 2018, 1:53 PM

Harbormaster completed remote builds in B21244: Diff 47393.Dec 4 2018, 1:55 PM

epriestley requested review of this revision.Dec 4 2018, 1:55 PM

amckinley accepted this revision.Dec 5 2018, 4:36 PM

This revision is now accepted and ready to land.Dec 5 2018, 4:36 PM

Closed by commit rP70bf63bc3adc: Fix a transaction editor "continue;" inside "switch()" for PHP 7.3 (authored by epriestley). · Explain WhyDec 5 2018, 7:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestTransactionEditor.php

2 lines

Diff 47393

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Fix a transaction editor "continue;" inside "switch()" for PHP 7.3ClosedPublicActions