Page MenuHomePhabricator
Differential D19844

Fix a transaction editor "continue;" inside "switch()" for PHP 7.3
ClosedPublic
Actions

Authored by epriestley on Dec 4 2018, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 3, 2:35 AM
Unknown Object (File)
Fri, Jan 31, 8:30 AM
Unknown Object (File)
Mon, Jan 27, 8:59 PM
Unknown Object (File)
Sat, Jan 25, 2:41 AM
Unknown Object (File)
Sat, Jan 25, 2:41 AM
Unknown Object (File)
Sat, Jan 25, 2:41 AM
Unknown Object (File)
Sat, Jan 25, 2:41 AM
Unknown Object (File)
Sun, Jan 12, 6:48 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP70bf63bc3adc: Fix a transaction editor "continue;" inside "switch()" for PHP 7.3
Summary

See https://discourse.phabricator-community.org/t/new-git-commit-processing-fails-on-php-7-3/. This "continue" should be a "break".

Test Plan

Screen Shot 2018-12-04 at 5.52.33 AM.png (264×453 px, 25 KB)

  • Tried to assign a task to myself while I was already the owner, got an appropriate error.

Diff Detail

Repository
rP Phabricator
Branch
continue1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21244
Build 28893: Run Core Tests
Build 28892: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
editor/
2 lines

Diff 47393

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
Phabricator · Built by Phacility