Page MenuHomePhabricator
Differential D19841

Add support for "harbormaster.target.search"
ClosedPublic
Actions

Authored by epriestley on Nov 26 2018, 4:05 PM.
Tags
None
Referenced Files
F13223859: D19841.diff
Sun, May 19, 5:09 AM
F13217786: D19841.id47385.diff
Sat, May 18, 8:02 AM
F13186496: D19841.id.diff
Sat, May 11, 3:40 AM
Unknown Object (File)
Sun, May 5, 2:36 AM
Unknown Object (File)
Fri, May 3, 11:43 AM
Unknown Object (File)
Thu, May 2, 7:33 AM
Unknown Object (File)
Wed, May 1, 7:55 AM
Unknown Object (File)
Mon, Apr 29, 6:12 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rP01c7be059dd6: Add support for "harbormaster.target.search"
Summary

Ref T13222. See PHI986. See PHI896. Harbormaster build targets don't currently have a modern "*.search" API, but there's no reason not to provide one (even if some of the use cases are a little bit questionable).

Test Plan

Screen Shot 2018-11-26 at 8.03.23 AM.png (1×2 px, 241 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 26 2018, 4:05 PM
Owners added a subscriber: Restricted Owners Package.Nov 26 2018, 4:05 PM
Harbormaster completed remote builds in B21220: Diff 47371.Nov 26 2018, 4:06 PM
epriestley requested review of this revision.Nov 26 2018, 4:06 PM
amckinley accepted this revision.Nov 28 2018, 6:43 PM
This revision is now accepted and ready to land.Nov 28 2018, 6:43 PM
Closed by commit rP01c7be059dd6: Add support for "harbormaster.target.search" (authored by epriestley). · Explain WhyNov 28 2018, 9:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
conduit/
18 lines
query/
73 lines
storage/
build/
84 lines

Diff 47385

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterTargetSearchAPIMethod.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildTargetSearchEngine.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

Loading...
Phabricator · Built by Phacility