Page MenuHomePhabricator

Allow "Abandoned" revisions to be commandeered
ClosedPublic

Authored by epriestley on Nov 24 2018, 2:53 PM.
Tags
None
Referenced Files
F14417721: D19835.id47374.diff
Wed, Dec 25, 2:04 AM
F14412204: D19835.diff
Tue, Dec 24, 12:46 PM
F14408106: D19835.diff
Tue, Dec 24, 4:08 AM
Unknown Object (File)
Tue, Dec 17, 9:58 AM
Unknown Object (File)
Mon, Dec 16, 7:16 AM
Unknown Object (File)
Sun, Dec 1, 3:57 PM
Unknown Object (File)
Sun, Dec 1, 11:39 AM
Unknown Object (File)
Sun, Dec 1, 11:39 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI985. You currently can't commandeer an abandoned revision, but this workflow is perfectly fine.

The caution here is just around weird use cases where, e.g., users want to reopen a revision to add a revert to it. These workflows tend to create problems so we try to guide users away from them.

Test Plan

Screen Shot 2018-11-24 at 6.47.21 AM.png (344×1 px, 44 KB)

Diff Detail

Repository
rP Phabricator
Branch
commab1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21209
Build 28845: Run Core Tests
Build 28844: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 26 2018, 4:50 PM
This revision was automatically updated to reflect the committed changes.