Page MenuHomePhabricator

Allow "Abandoned" revisions to be commandeered
ClosedPublic

Authored by epriestley on Nov 24 2018, 2:53 PM.
Tags
None
Referenced Files
F17320303: D19835.id47374.diff
Thu, Jun 26, 8:17 PM
Unknown Object (File)
Wed, Jun 4, 9:04 AM
Unknown Object (File)
May 10 2025, 8:03 AM
Unknown Object (File)
May 10 2025, 8:03 AM
Unknown Object (File)
May 10 2025, 8:03 AM
Unknown Object (File)
May 10 2025, 8:03 AM
Unknown Object (File)
Apr 30 2025, 11:40 AM
Unknown Object (File)
Apr 29 2025, 12:35 PM
Subscribers
None

Details

Summary

Ref T13216. See PHI985. You currently can't commandeer an abandoned revision, but this workflow is perfectly fine.

The caution here is just around weird use cases where, e.g., users want to reopen a revision to add a revert to it. These workflows tend to create problems so we try to guide users away from them.

Test Plan

Screen Shot 2018-11-24 at 6.47.21 AM.png (344×1 px, 44 KB)

Diff Detail

Repository
rP Phabricator
Branch
commab1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21209
Build 28845: Run Core Tests
Build 28844: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 26 2018, 4:50 PM
This revision was automatically updated to reflect the committed changes.