Paths

Table of Contentst

Differential D19825

Expose "identifiers" as a query constraint for Commit search
ClosedPublic
Actions

Authored by epriestley on Nov 21 2018, 4:48 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13216: 2018 Week 45-47 Bonus Content

Commits

rP45e93c8f1d1a: Expose "identifiers" as a query constraint for Commit search

Summary

Ref T13216. See PHI984. The CommitSearchEngine (and, by extension, diffusion.commit.search) currently do not support identifier search, but this is a reasonable capability to provide.

Test Plan

Testing that a commit exists on master:

Screen Shot 2018-11-21 at 8.46.19 AM.png (1×2 px, 230 KB)

Same commit is not on stable:

Screen Shot 2018-11-21 at 8.46.36 AM.png (1×2 px, 159 KB)

Diff Detail

Repository

rP Phabricator

Branch

identifiersapi1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21199
Build 28825: Run Core Tests
Build 28824: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 21 2018, 4:48 PM

Harbormaster completed remote builds in B21198: Diff 47349.Nov 21 2018, 4:50 PM

epriestley requested review of this revision.Nov 21 2018, 4:50 PM

Slightly better identifiers, fewer documentation typos.

Harbormaster completed remote builds in B21199: Diff 47350.Nov 21 2018, 4:55 PM

amckinley accepted this revision.Nov 23 2018, 2:24 PM

This revision is now accepted and ready to land.Nov 23 2018, 2:24 PM

Closed by commit rP45e93c8f1d1a: Expose "identifiers" as a query constraint for Commit search (authored by epriestley). · Explain WhyNov 24 2018, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

query/

PhabricatorCommitSearchEngine.php

13 lines

Diff 47350

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Expose "identifiers" as a query constraint for Commit searchClosedPublicActions