Page MenuHomePhabricator
Differential D19825

Expose "identifiers" as a query constraint for Commit search
ClosedPublic
Actions

Authored by epriestley on Nov 21 2018, 4:48 PM.
Tags
None
Referenced Files
F19082873: D19825.id47362.diff
Dec 2 2025, 12:26 PM
F19082872: D19825.id47350.diff
Dec 2 2025, 12:26 PM
F19024499: D19825.diff
Nov 24 2025, 3:36 AM
F19009783: D19825.diff
Nov 22 2025, 12:27 AM
F18984981: D19825.id47349.diff
Nov 17 2025, 12:50 PM
F18849003: D19825.id47349.diff
Oct 30 2025, 7:14 AM
F18832489: D19825.id.diff
Oct 25 2025, 10:01 PM
F18822313: D19825.diff
Oct 23 2025, 5:49 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13216: 2018 Week 45-47 Bonus Content
Commits
rP45e93c8f1d1a: Expose "identifiers" as a query constraint for Commit search
Summary

Ref T13216. See PHI984. The CommitSearchEngine (and, by extension, diffusion.commit.search) currently do not support identifier search, but this is a reasonable capability to provide.

Test Plan

Testing that a commit exists on master:

Screen Shot 2018-11-21 at 8.46.19 AM.png (1×2 px, 230 KB)

Same commit is not on stable:

Screen Shot 2018-11-21 at 8.46.36 AM.png (1×2 px, 159 KB)

Diff Detail

Repository
rP Phabricator
Branch
identifiersapi1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21198
Build 28823: Run Core Tests
Build 28822: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
query/
13 lines

Diff 47349

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
Phabricator · Built by Phacility