Page MenuHomePhabricator

Define "idle" connections that are safe to close (no transactions, no held locks)
ClosedPublic

Authored by epriestley on Nov 20 2018, 6:47 PM.
Tags
None
Referenced Files
F13177191: D19823.diff
Wed, May 8, 7:32 PM
Unknown Object (File)
Thu, May 2, 2:36 AM
Unknown Object (File)
Tue, Apr 30, 5:40 PM
Unknown Object (File)
Mon, Apr 29, 1:55 PM
Unknown Object (File)
Wed, Apr 24, 10:01 PM
Unknown Object (File)
Sun, Apr 21, 4:07 PM
Unknown Object (File)
Wed, Apr 17, 3:08 PM
Unknown Object (File)
Thu, Apr 11, 7:17 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI916. When workers are spending 20 minutes in ssh ... ./run-huge-build.sh, we'd like to drop database connections to reduce the cost of having a large fleet of build agents.

To prepare for this, define what it means for a connection to be "idle": no held locks and no open transactions. These connections are safe to close without loss of state.

Test Plan

See next revision for use.

Diff Detail

Repository
rPHU libphutil
Branch
idle1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21193
Build 28816: Run Core Tests
Build 28815: arc lint + arc unit