Page MenuHomePhabricator

Further refine the Java syntax lexer for escaped strings
ClosedPublic

Authored by epriestley on Oct 25 2018, 4:32 PM.
Tags
None
Referenced Files
F15512950: D19763.id.diff
Thu, Apr 17, 3:07 PM
F15508314: D19763.diff
Wed, Apr 16, 4:36 AM
F15454904: D19763.diff
Sat, Mar 29, 9:12 PM
F15447826: D19763.diff
Fri, Mar 28, 1:47 AM
F15445054: D19763.id47198.diff
Thu, Mar 27, 12:22 PM
F15427560: D19763.id47198.diff
Sun, Mar 23, 2:56 PM
F15417348: D19763.id47198.diff
Thu, Mar 20, 4:42 PM
F15333387: D19763.id47198.diff
Mar 8 2025, 2:05 AM
Subscribers
None

Details

Summary

Ref T13210. See PHI886. Previously, D19731 improved some behavior here, but didn't go quite far enough and we still got strings with \" wrong.

Parse backslash followed by anything, or any character except double quote or backslash.

(If this is still somehow wrong I can just copy one of the other lexers which is a little more complicated but gets this right.)

Test Plan

Screen Shot 2018-10-25 at 9.30.40 AM.png (591×275 px, 26 KB)

Diff Detail

Repository
rPHU libphutil
Branch
java2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21043
Build 28595: Run Core Tests
Build 28594: arc lint + arc unit